[libvirt] [PATCH v2 11/11] conf: Skip post parse callbacks when creating copy

[Jiri Denemark]

On Fri, Sep 23, 2016 at 15:25:04 +0200, Michal Privoznik wrote:
> When creating a copy of virDomainDef we save ourselves the
> trouble of writing deep-copy functions and just format and parse
> back domain/device XML. However, the XML we are parsing was
> already fully formatted - there is no reason to run post parse
> callbacks (which fill in blanks - there are none!).
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/domain_conf.c | 6 ++++--
>  src/qemu/qemu_domain.c | 3 ++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index bd20b74..976fe78 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -24682,7 +24682,8 @@ virDomainDefCopy(virDomainDefPtr src,
>      virDomainDefPtr ret;
>      unsigned int format_flags = VIR_DOMAIN_DEF_FORMAT_SECURE;
>      unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE |
> -                               VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE;
> +                               VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE |
> +                               VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE;
>  
>      if (migratable)
>          format_flags |= VIR_DOMAIN_DEF_FORMAT_INACTIVE | VIR_DOMAIN_DEF_FORMAT_MIGRATABLE;
...

I'd squash this to the previous patch.

ACK

Jirka