[libvirt] [PATCH v3 1/4] conf: add xen type for channels

[Joao Martins]

On 09/27/2016 05:05 AM, Jim Fehlig wrote:
> On 09/26/2016 11:33 AM, Joao Martins wrote:
>> So far only guestfwd and virtio were supported. Add an additional
>> for Xen as libxl channels create Xen console visible to the guest.
>>
>> Signed-off-by: Joao Martins <joao.m.martins at oracle.com>
>> ---
>> Changes since v2:
>>  * Add relevant documentation about target type xen.
>> ---
>>  docs/formatdomain.html.in     | 10 ++++++++++
>>  docs/schemas/domaincommon.rng | 11 +++++++++++
>>  src/conf/domain_conf.c        | 18 ++++++++++++++----
>>  src/conf/domain_conf.h        |  1 +
>>  src/qemu/qemu_command.c       |  1 +
>>  5 files changed, 37 insertions(+), 4 deletions(-)
>>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index f48a4d8..129ba62 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -5980,6 +5980,16 @@ qemu-kvm -net nic,model=? /dev/null
>>          Possible values for the <code>state</code> attribute are
>>          <code>connected</code> and <code>disconnected</code>.
>>        </dd>
>> +      <dt><code>xen</code></dt>
>> +      <dd> Paravirtualized xen channel. Channel is exposed in the guest as a
>> +        xen console but identified with a name. The setup of the channel
>> +        depends to guest own rules and can live in a arbitrary path (for more
>> +        info, please see <a href="http://xenbits.xen.org/docs/unstable/misc/channel.txt">http://xenbits.xen.org/docs/unstable/misc/channel.txt</a>).
> 
> The last sentence is not clear IMO and I'd like to improve it before pushing
> this series. What do you think of the below diff? Or feel free to propose
> something better :-).
Much cleared indeed, it looks good to me. Specially the changes to the first
sentences.. I was sort of searching for that kind of working when making that text.

Joao

> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 129ba62..7008005 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -5981,12 +5981,12 @@ qemu-kvm -net nic,model=? /dev/null
>          <code>connected</code> and <code>disconnected</code>.
>        </dd>
>        <dt><code>xen</code></dt>
> -      <dd> Paravirtualized xen channel. Channel is exposed in the guest as a
> -        xen console but identified with a name. The setup of the channel
> -        depends to guest own rules and can live in a arbitrary path (for more
> -        info, please see <a
> href="http://xenbits.xen.org/docs/unstable/misc/channel.txt">http://xenbits.xen.org/docs/unstable/misc/channel.txt</a>).
> +      <dd> Paravirtualized Xen channel. Channel is exposed in the guest as a
> +        Xen console but identified with a name. Setup and consumption of a Xen
> +        channel depends on software and configuration in the guest
> +        (for more info, please see <a
> href="http://xenbits.xen.org/docs/unstable/misc/channel.txt">http://xenbits.xen.org/docs/unstable/misc/channel.txt</a>).
>          Channel source path semantics are the same as the virtio target type.
> -        Although <code>state</code> attribute is not provided as xen channels
> +        The <code>state</code> attribute is not supported since Xen channels
>          lack the necessary probing mechanism.
>          <span class="since">Since 2.3.0</span>
>        </dd>
> 
> 
> Regards,
> Jim
>