[libvirt] [libvirt-php][PATCH 00/11] Resolve reverse include order

Michal Privoznik mprivozn at redhat.com
Tue Sep 27 13:11:03 UTC 2016


These are not pushed yet as they might be somewhat controversial.
I'll wait if somebody wants to review them.

The ultimate goal is to, well drop libvirt-php.h completely. It
is needless. But before going there we must distribute the
interesting parts from it around. Therefore I'm introducing some
modules (like it should have been done from the start).

Anyway, happy coding!

Michal Privoznik (11):
  vncfunc: Honour static function
  Move DEFAULT_LOG_MAXSIZE to libvirt-php.c
  Move VNC_MAX_AUTH_ATTEMPTS to vncfunc.c
  libvirt-php.c: Move system headers together
  src: Introduce util.h
  src: Introduce util.c
  src: Introduce vncfunc.h
  src: Introduce sockets.h
  vncfunc: Drop include of libvirt-php.h
  sockets: Drop include of libvirt-php.h
  Clean up debug macros

 configure.ac      |  1 +
 src/Makefile.am   |  5 ++--
 src/config.m4     |  2 +-
 src/libvirt-php.c | 69 +++++++++++++++++----------------------------
 src/libvirt-php.h | 81 -----------------------------------------------------
 src/sockets.c     | 24 +++++++++++-----
 src/sockets.h     | 32 +++++++++++++++++++++
 src/util.c        | 73 ++++++++++++++++++++++++++++++++++++++++++++++++
 src/util.h        | 73 ++++++++++++++++++++++++++++++++++++++++++++++++
 src/vncfunc.c     | 83 +++++++++++++++++++++++++++++++++++++++++--------------
 src/vncfunc.h     | 38 +++++++++++++++++++++++++
 11 files changed, 325 insertions(+), 156 deletions(-)
 create mode 100644 src/sockets.h
 create mode 100644 src/util.c
 create mode 100644 src/util.h
 create mode 100644 src/vncfunc.h

-- 
2.8.4




More information about the libvir-list mailing list