[libvirt] [PATCH v2] qemu: Fix crash in qemucapsprobe

[John Ferlan]

On 09/27/2016 01:25 PM, Jiri Denemark wrote:
> The qemucapsprobe helper calls virQEMUCapsNewForBinaryInternal with
> caps == NULL, causing the following crash:
> 
>     Program received signal SIGSEGV, Segmentation fault.
>     #0  0x00007ffff788775f in virQEMUCapsInitHostCPUModel
>         (qemuCaps=qemuCaps at entry=0x649680, host=host at entry=0x10) at
>         src/qemu/qemu_capabilities.c:2969
>     #1  0x00007ffff7889dbf in virQEMUCapsNewForBinaryInternal
>         (caps=caps at entry=0x0, binary=<optimized out>,
>         libDir=libDir at entry=0x4033f6 "/tmp", cacheDir=cacheDir at entry=0x0,
>         runUid=runUid at entry=4294967295, runGid=runGid at entry=4294967295,
>         qmpOnly=true) at src/qemu/qemu_capabilities.c:4039
>     #2  0x0000000000401702 in main (argc=2, argv=0x7fffffffd968) at
>         tests/qemucapsprobe.c:73
> 
> Caused by v2.2.0-182-g68c7011.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 15 +++++++++------
>  src/qemu/qemu_capspriv.h     |  2 +-
>  tests/qemuxml2argvtest.c     |  2 +-
>  3 files changed, 11 insertions(+), 8 deletions(-)
> 

ACK (and save for freeze)

John