[libvirt] [PATCH] libxl: fix param assignment in domainGetSchedulerParameters

Jim Fehlig jfehlig at suse.com
Wed Sep 28 13:58:16 UTC 2016


On 09/28/2016 05:47 AM, John Ferlan wrote:
>
> On 09/28/2016 12:33 AM, Jim Fehlig wrote:
>> Due to a copy and paste error, the scheduler 'cap' parameter
>> was over-writing the 'weight' parameter when preparing the
>> return parameters in libxlDomainGetSchedulerParametersFlags.
>> As a result, the scheduler weight was never shown when getting
>> schedinfo and setting the weight failed as well
>>
>> virsh  schedinfo testvm
>> Scheduler      : credit
>> cap            : 0
>>
>> virsh  schedinfo testvm --cap 50 --weight 500
>> Scheduler      : credit
>> error: invalid scheduler option: weight
>>
>> The obvious fix is to assign the 'caps' parameter to the correct
>> item in the parameter list.
>>
>> Reported-by: Volo M. <vm at vovs.net>
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>> ---
>>  src/libxl/libxl_driver.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> ACK (and safe)

Thanks! Pushed now.

Regards,
Jim




More information about the libvir-list mailing list