[libvirt] [PATCH] qemu: Only use memory-backend-file with NUMA if needed

[Martin Kletzander]

On Tue, Sep 27, 2016 at 04:29:07PM +0200, Michal Privoznik wrote:
>On 23.09.2016 15:20, Martin Kletzander wrote:
>> If this reminds you of a commit message from around a year ago, it's
>> 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with
>> "the same thing" again.  Or f309db1f4d51009bad0d32e12efc75530b66836b and
>> it's similar.
>>
>> There is a logic in place that if there is no real need for
>> memory-backend-file, qemuBuildMemoryBackendStr() returns 0.  However
>> that wasn't the case with hugepage backing.  The reason for that was
>> that we abused the 'pagesize' variable for storing that information, but
>> we should rather have a separate one that specifies whether we really
>> need the new object for hugepage backing.  And that variable should be
>> set only if this particular NUMA cell needs special treatment WRT
>> hugepages.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1372153
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>
>> Notes:
>>     This fixes migration from older libvirts.  By "older", I mean
>>     pre-(circa-)1.2.7, also in some cases pre-1.2.11, in some other cases
>>     pre-v1.2.20.  It's pretty messy.  It could be back-ported as far as it's
>>     easy to do.
>>
>>  src/qemu/qemu_command.c                                   |  8 +++++---
>>  tests/qemuxml2argvdata/qemuxml2argv-hugepages-pages2.args | 10 ++++------
>>  2 files changed, 9 insertions(+), 9 deletions(-)
>
>ACK
>

Since this was ACKed before the freeze, I'll pushed it in a while,
mainly because I need to back-port it to -maint branches anyway.

>Michal
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160929/d5c33f20/attachment-0001.sig>