[libvirt] [PATCH 3/3] introduce pull backup

[Kashyap Chamarthy]

On Thu, Sep 29, 2016 at 06:02:08PM -0400, John Ferlan wrote:

[...]

> >> Because it's also dependent upon an x-blockdev-del, it cannot be pushed
> >> upstream to libvirt. I know qemu work continues w/r/t blockdev-add and
> >> backups, but I don't follow it in detail (not enough time in the day!).
> > 
> > Ok, at least the patch can be some kind of candidate to be pushed upstream
> > as soon as blockdev-del drops x- prefix.
> > 
> 
> Not as a single patch though - I have a feeling you're going to have a
> git branch committed to this for a while...  Consider my recent response
> to your 1/3 patch w/r/t qemu's statement about the blockdev-add command...
> 
> My *guess* is when 'blockdev-del' is officially supported - that's when
> libvirt can "assume" support for blockdev-add (since the x- was taken
> off of it - something that we can document when that happens).

There was a related discussion on qemu-devel this week, where Kevin Wolf
writes:

    "Just to clarify what "not stable" means: Literally none of the
    blockdev-add commands that used to work when it was originally
    merged are still working. And we're considering another similar
    change (removing the "options" indirection) that will change the
    command for all users. So while I would encourage libvirt to write
    prototyp code for supporting blockdev-add now, I would advise
    against enabling it in a release yet."

        https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg07748.html

The "x-" prefix for 'blockdev-add' was inadvertently missed:

    https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg07765.html

Kevin also clarifies:

    "Don't use blockdev-add until x-blockdev-del has been renamed." --
    https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg07773.html

[...]

-- 
/kashyap