[libvirt] [PATCH v5 0/2] qemu/gluster: add option for tuning debug logging level

Prasanna Kalever pkalever at redhat.com
Fri Sep 30 14:45:38 UTC 2016


On Thu, Sep 29, 2016 at 7:49 PM, Peter Krempa <pkrempa at redhat.com> wrote:
>
> On Thu, Sep 22, 2016 at 01:04:17 +0530, Prasanna Kumar Kalever wrote:
> > This series run basic sanity and other tests:
> > 1. make syntax-check
> > 2. make check
> > 3. VIR_TEST_VERBOSE=1 ./tests/qemuargv2xmltest
> > 4. VIR_TEST_VERBOSE=1 ./tests/qemuxml2argvtest
> > 5. VIR_TEST_VERBOSE=1 ./tests/qemucapabilitiestest
> >
> > v5:
> > Avoild copying variable glusterDebugLevel to disk->src (virStorageSourcePtri),
> > instead get debug_level from cfg as per Jiri Denemark review on v4
> > Thanks Jirka
>
> The patches still should be in reverse order and I still don't think
> that's impossible to do a proper feature check for the qemu capability.
>
> I'll pick them up and try to figure it out once I have time.

Thanks for you email Peter!


Sure, and also please do let me know if you feel convenient to see
them as one single patch, I can rework on them.
Apart from the order/layout, does these patches addresses all the
previous reviews? or I'm I still missing something?

--
Prasanna

>
> Peter




More information about the libvir-list mailing list