[libvirt] [PATCH v2 2/5] storage: util: Split out the gluster volume extraction code into new function

[Peter Krempa]

On Mon, Apr 03, 2017 at 16:20:26 +0200, Andrea Bolognani wrote:
> On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote:
> [...]
> > @@ -93,6 +93,10 @@ int virStorageBackendDeleteLocal(virConnectPtr conn,
> >  int virStorageBackendRefreshLocal(virConnectPtr conn,
> >                                    virStoragePoolObjPtr pool);
> > 
> > +int virStorageUtilGlusterExtractPoolSources(const char *host,
> > +                                            const char *xml,
> > +                                            virStoragePoolSourceListPtr list,
> > +                                            bool netfs);
> 
> Please add a comment along the lines of "For test suite use
> only" here. Ideally we'd have a separate *priv.h header file
> to be used for the purpose, but that's out of scope.

Why? This function can be used wherever it's necessary. It's by no-means
specific to the test suite.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170403/a7faa0b4/attachment-0001.sig>