[libvirt] [PATCH v2 5/5] storage: gluster: Use volume name as "<name>" field in the XML

[Andrea Bolognani]

On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote:
[...]
> +        if (netfs) {
> +            src->format = VIR_STORAGE_POOL_NETFS_GLUSTERFS;
> +            src->dir = volname;
> +        } else {
> +            src->name = volname;
> +
> +            if (VIR_STRDUP(src->dir, "/") < 0)
> +                goto cleanup;

I'll admit I didn't dig, but is hardcoding "/" here the
right thing to do?

Assuming it is because some other code takes care of setting
it to a different value when needed,

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization