[libvirt] [PATCH] docs: don't install news.rng file
Bjoern Walk
bwalk at linux.vnet.ibm.com
Wed Apr 5 07:17:02 UTC 2017
Peter Krempa <pkrempa at redhat.com> [2017-04-05, 08:44AM +0200]:
>On Wed, Apr 05, 2017 at 07:58:36 +0200, Bjoern Walk wrote:
>> Daniel P. Berrange <berrange at redhat.com> [2017-04-04, 07:24PM +0200]:
>> > The news.rng file gets picked up by the wildcard match on docs/schemas,
>> > and so gets installed into /usr/share/libvirt, along with the schemas
>> > for our API objects. This then generated an RPM build failure, since
>> > we don't have news.rng in the RPM file list
>> >
>> > The news.rng schema is not something that users of libvirt ever care
>> > about, since it is purely an internal thing to validate our website
>> > content.
>> >
>> > So rather than add news.rng to the RPM file list, this changes the
>> > make rules so that we don't install news.rng at all.
>> >
>> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
>> > ---
>> >
>> > Technically a built-break fix, but I'm not pushing it, in case people
>> > have any alternative suggestions. eg we could just put news.rng in
>> > the tests/ subdirectory instead, letting us keep the wildcard in the
>> > docs/Makefile.am
>>
>> I would actually prefer this solution. The current place feels weirdly
>> wrong.
>
>Describe the wrongness please. It's together with other schemas in the
>directory containing documentation. The place makes sense. Only thing
>which does not is that it would be installed.
It's an auxiliary file to solve a build(?)-specific problem, not like
the other rngs. I actually tried to solve this failure yesterday by
adding the news.rng to the spec file and it didn't fit anywhere. So, it
just feels in the wrong place.
I like you suggestion to put the news.rng next to the news.xml, it would
make sense to have them paired and it gets the news.rng out of the way.
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk at de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 896 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170405/d31aac44/attachment-0001.sig>
More information about the libvir-list
mailing list