[libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

Ján Tomko jtomko at redhat.com
Wed Apr 5 10:04:37 UTC 2017


On Wed, Mar 29, 2017 at 04:08:53PM +0200, Andrea Bolognani wrote:
>The capabilities used in test cases should match those used
>during normal operation for the tests to make any sense.
>---
> src/qemu/qemu_capabilities.c                                          | 2 +-
> src/qemu/qemu_capabilities.h                                          | 2 ++
> tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args             | 1 -

[...]

> tests/qemuxml2argvdata/qemuxml2argv-watchdog-diag288.args             | 1 -
> tests/qemuxml2argvtest.c                                              | 4 ++--
> 55 files changed, 7 insertions(+), 53 deletions(-)
>

>diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
>index d44682f..24e2f38 100644
>--- a/src/qemu/qemu_capabilities.h
>+++ b/src/qemu/qemu_capabilities.h
>@@ -510,6 +510,8 @@ int virQEMUCapsParseHelpStr(const char *qemu,
>                             const char *qmperr);
> /* Only for use by test suite */
> int virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps, const char *str);
>+/* Only for use by test suite */
>+void virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps);

We have qemu_capspriv.h for functions used by the test suite
guarded by the __QEMU_CAPSPRIV_H_ALLOW__ define.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170405/ce246684/attachment-0001.sig>


More information about the libvir-list mailing list