[libvirt] [PATCH] Expose resource control capabilites on cache bank

Eli Qiao qiaoliyong at gmail.com
Thu Apr 6 11:31:00 UTC 2017



On Thursday, 6 April 2017 at 5:51 PM, Daniel P. Berrange wrote:

> On Thu, Apr 06, 2017 at 11:49:14AM +0200, Martin Kletzander wrote:
> > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote:
> > > This patch is based on Martin's cache branch.
> > > 
> > > This patch amends the cache bank capability as follow:
> > > 
> > > <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'/>
> > > <control min='768' unit='KiB' type='unified' nclos='4'/>
> > > <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'/>
> > > <control min='768' unit='KiB' type='unified' nclos='4'/>
> > > 
> > 
> > 
> 
> 
> Either the XML is malformed, or the indentation is wrong. The indentation
> suggests you want nested XML elements, but the parent element is an empty
> tag, so you've actually got a flat namespace here.
> 

<cache>
  <bank id='0' level='3' type='unified' size='15360' unit='KiB' cpus='0-5'/>
    <control min='768' unit='KiB' type='unified' nallocations='4'/>
  <bank id='1' level='3' type='unified' size='15360' unit='KiB' cpus='6-11'/>
    <control min='768' unit='KiB' type='unified' nallocations='4'/>
</cache>


I validate it online, no errors, the result is:
 
http://www.xmlvalidation.com/index.php?id=1&L=0&target=/xmlvalidation/start.jsp;jsessionid=5B8746DEE269CE0ADFB1B8F88CF5E94F
 
> 
> > > 
> > 
> > 
> > Were we exposing the number of CLoS IDs before? Was there a discussion
> > about it? Do we want to expose them? Probably yes, I'm just wondering.
> > 
> 
> 
> What are CLoS IDs and what are they used for ?
> 
> 
> 
> Regards,
> Daniel
> -- 
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org :|
> |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com (mailto:libvir-list at redhat.com)
> https://www.redhat.com/mailman/listinfo/libvir-list
> 
> 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170406/b4840265/attachment-0001.htm>


More information about the libvir-list mailing list