[libvirt] [PATCH 3/8] qemu: Always reset TLS in qemuProcessRecoverMigrationOut

Peter Krempa pkrempa at redhat.com
Fri Apr 7 07:44:02 UTC 2017


On Wed, Apr 05, 2017 at 15:09:58 +0200, Jiri Denemark wrote:
> qemuProcessRecoverMigrationOut doesn't explicitly call
> qemuMigrationResetTLS relying on two things:
> 
>     - qemuMigrationCancel resets TLS parameters
>     - our migration code resets TLS before entering
>       QEMU_MIGRATION_PHASE_PERFORM3_DONE phase
> 
> But this is not obvious and the assumptions will be broken soon. Let's
> explicitly reset TLS parameters on all paths which do not kill the
> domain.

We are still fond of the XEN heritage?

> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_process.c | 1 +
>  1 file changed, 1 insertion(+)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170407/8ed6e55e/attachment-0001.sig>


More information about the libvir-list mailing list