[libvirt] [PATCH v2 07/12] tests: Add missing cache data for vircaps2xmltest

Martin Kletzander mkletzan at redhat.com
Fri Apr 7 09:42:32 UTC 2017


On Fri, Apr 07, 2017 at 10:39:17AM +0200, Erik Skultety wrote:
>> diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id
>> new file mode 100644
>> index 000000000000..573541ac9702
>> --- /dev/null
>> +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id
>> @@ -0,0 +1 @@
>> +0
>> diff --git a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list
>> index d41d18ba0096..8b0fab869c1d 100644
>> --- a/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list
>> +++ b/tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list
>> @@ -1 +1 @@
>> -0,4
>> +0-1
>
>Honestly, I have absolutely no idea, how I should check this (same goes for the
>rest of the patch). I'm just going to trust you here, say ACK because it builds
>and hide in the corner (just in case it's broken somehow).
>

I took it from another machine originally, I haven't realized I'm
changing some of these, but this is what the tests are added for, so
I'll keep this one.

>Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170407/df8a0406/attachment-0001.sig>


More information about the libvir-list mailing list