[libvirt] [PATCH] esx: Fix memory leak

Wang King king.wang at huawei.com
Wed Apr 12 10:06:44 UTC 2017


Variable def going out of scope leaks the storage def.source.hosts points to.
---
 src/esx/esx_storage_backend_vmfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backend_vmfs.c
index a1a660b..940e5d1 100644
--- a/src/esx/esx_storage_backend_vmfs.c
+++ b/src/esx/esx_storage_backend_vmfs.c
@@ -513,6 +513,7 @@ esxStoragePoolGetXMLDesc(virStoragePoolPtr pool, unsigned int flags)
     xml = virStoragePoolDefFormat(&def);
 
  cleanup:
+    VIR_FREE(def.source.hosts);
     esxVI_String_Free(&propertyNameList);
     esxVI_ObjectContent_Free(&datastore);
     esxVI_DatastoreHostMount_Free(&hostMount);
-- 
2.8.3





More information about the libvir-list mailing list