[libvirt] [PATCH] xenconfig: avoid double free on OOM testing

Peter Krempa pkrempa at redhat.com
Tue Apr 18 08:16:56 UTC 2017


On Thu, Apr 13, 2017 at 11:07:41 -0600, Jim Fehlig wrote:
> Fix xlconfig channel tests when OOM testing is enabled.
> 
> TEST: xlconfigtest
> 32) Xen XL-2-XML Format channel-unix                                  ... OK
>     Test OOM for nalloc=55 ................................................*** Error in `/home/jfehlig/virt/upstream/libvirt/tests/.libs/xlconfigtest': double free or corruption (fasttop): 0x0000000000679550 ***
> ...
> (gdb) bt
> #0  0x00007ffff36875af in raise () from /lib64/libc.so.6
> #1  0x00007ffff36889aa in abort () from /lib64/libc.so.6
> #2  0x00007ffff36c5150 in __libc_message () from /lib64/libc.so.6
> #3  0x00007ffff36cb4f6 in malloc_printerr () from /lib64/libc.so.6
> #4  0x00007ffff36cbcee in _int_free () from /lib64/libc.so.6
> #5  0x00007ffff782babf in virFree (ptrptr=0x7fffffffdca8) at util/viralloc.c:582
> #6  0x000000000042f2f3 in xenParseXLChannel (conf=0x677350, def=0x6815b0) at xenconfig/xen_xl.c:788
> #7  0x000000000042f44e in xenParseXL (conf=0x677350, caps=0x6832b0, xmlopt=0x67f6e0) at xenconfig/xen_xl.c:828
> #8  0x00000000004105a3 in testCompareFormatXML (
>     xlcfg=0x6811e0 "/home/jfehlig/virt/upstream/libvirt/tests/xlconfigdata/test-channel-unix.cfg",
>     xml=0x681110 "/home/jfehlig/virt/upstream/libvirt/tests/xlconfigdata/test-channel-unix.xml", replaceVars=false)
>     at xlconfigtest.c:152
> 
> When a channel is successfully parsed and its path and name fields
> assigned from local variables, set the local variables to NULL to
> prevent a double free on error.
> 
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
>  src/xenconfig/xen_xl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170418/ba9684b9/attachment-0001.sig>


More information about the libvir-list mailing list