[libvirt] [PATCH 3/4] qemu: report IDE bus in domain capabilities only if it's supported

[Pavel Hrdina]

On Tue, Apr 18, 2017 at 12:08:30PM +0200, Peter Krempa wrote:
> On Tue, Apr 18, 2017 at 12:00:12 +0200, Pavel Hrdina wrote:
> > On Tue, Apr 18, 2017 at 11:31:20AM +0200, Peter Krempa wrote:
> > > On Thu, Apr 13, 2017 at 16:57:15 +0200, Pavel Hrdina wrote:
> > > 
> > > Was this the problem that virt-manager allowed to use the IDE bus on
> > > Q35?
> > 
> > Yes :)
> 
> Then please add something like "Since virt-manager (virt-install?) uses
> this data it would allow to create configuration which would be rejected
> by libvirt." or something like that ...

I don't see any value in mentioning virt-manager in commit message,
the domain capability output is wrong regardless of who uses it.

> > 
> > > 
> > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1441964
> 
> Since this BZ does not clearly state that fact.
> 
> > > > 
> > > > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > > > ---
> > > >  src/qemu/qemu_capabilities.c                                 | 4 +++-
> > > >  tests/domaincapsschemadata/qemu_2.6.0-gicv2-virt.aarch64.xml | 1 -
> > > >  tests/domaincapsschemadata/qemu_2.6.0-gicv3-virt.aarch64.xml | 1 -
> > > >  tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml            | 1 -
> > > >  tests/domaincapsschemadata/qemu_2.6.0.ppc64le.xml            | 1 -
> > > >  tests/domaincapsschemadata/qemu_2.7.0.s390x.xml              | 1 -
> > > >  tests/domaincapsschemadata/qemu_2.8.0.s390x.xml              | 1 -
> > > >  7 files changed, 3 insertions(+), 7 deletions(-)
> > > 
> > > ACK,
> > > 
> > > but I think you should follow up and do the same for the floppy device
> > > which AFAIK does not exist on aarch64 and others. There was an attempt
> > > to do this but only for ppc in 020a178318
> > 
> > There is a lot of space for improvement, I'll add it to my todo list :)
> 
> Yes. There is. As in every other part of libvirt :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170418/bec01ddf/attachment-0001.sig>