[libvirt] [PATCH] Remove pointless check for !ret in virDomainNetDefCoalesceParseXML

Martin Kletzander mkletzan at redhat.com
Sat Apr 22 16:39:17 UTC 2017


It was left there after removing a macro it was part of in first
version or so.  Now it will always be NULL.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
Pushed as trivial

 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4a777d67bfad..7d3cf178eaf6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6789,7 +6789,7 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node,
     if (!str)
         goto cleanup;

-    if (!ret && VIR_ALLOC(ret) < 0)
+    if (VIR_ALLOC(ret) < 0)
         goto cleanup;

     if (virStrToLong_ullp(str, NULL, 10, &tmp) < 0) {
--
2.12.2




More information about the libvir-list mailing list