[libvirt] [PATCH] util: relax virNetDevSetCoalesce() stub

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Apr 24 12:32:24 UTC 2017


  Martin Kletzander wrote:

> On Sun, Apr 23, 2017 at 06:57:07PM +0400, Roman Bogorodskiy wrote:
> >Currently, virNetDevSetCoalesce() stub is always returning error. As
> >it's used by virNetDevTapCreateInBridgePort(), it essentially breaks
> >bridged networking if coalesce is not supported.
> >
> >To make it work, relax the stub to trigger error only when its
> >coalesce argument is not NULL, otherwise report success.
> >---
> > src/util/virnetdev.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> 
> That should be fixed in the other stub as well.  ACK with that added.

Adjusted the other stub and pushed, thanks!

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170424/4565c1ee/attachment-0001.sig>


More information about the libvir-list mailing list