[libvirt] [PATCH v3 0/5] Alter the clearing of device for new partition table

Michal Privoznik mprivozn at redhat.com
Tue Apr 25 06:57:01 UTC 2017


On 04/07/2017 06:30 PM, John Ferlan wrote:
> Well kind of a v2/v3 type mashup - essentially reworked the portion of
> the series:
>
> https://www.redhat.com/archives/libvir-list/2017-April/msg00402.html
>
> that dealt with the zeroing of the header of the device path. The changes
> now will allow both the head and tail of the device path to be cleared
> rather than just the header of the file which was ACK'd for at least the
> logical backend.
>
> Additionally, bump the size of the clear/zero from 2048KB to 1MB and use
> it for both the logical and disk backends.
>
> John Ferlan (5):
>   storage: Modify storageBackendWipeLocal to allow zero from end of
>     device
>   storage: Introduce virStorageBackendZeroPartitionTable
>   logical: Use virStorageBackendZeroPartitionTable
>   logical: Increase the size of the data to wipe
>   disk: Use virStorageBackendZeroPartitionTable
>
>  src/storage/storage_backend_disk.c    |  6 ++-
>  src/storage/storage_backend_logical.c | 44 +---------------------
>  src/storage/storage_util.c            | 70 ++++++++++++++++++++++++++++-------
>  src/storage/storage_util.h            |  4 ++
>  4 files changed, 67 insertions(+), 57 deletions(-)
>

ACK series. But please see my comments before pushing - you'll need to 
fix couple of things before.

Michal




More information about the libvir-list mailing list