[libvirt] [PATCH 14/14] secret: Clean up virSecretObjListExport logic

Pavel Hrdina phrdina at redhat.com
Tue Apr 25 13:06:17 UTC 2017


On Mon, Apr 24, 2017 at 02:00:23PM -0400, John Ferlan wrote:
> Shorten the time needed to keep the list lock and alter the cleanup
> path to be more of an error path.
> 
> Utilize the the virObjectListFree function to handle the calls for
> virObjectUnref on each list element and the VIR_FREE of the list
> instead of open coding it.
> 
> Change the name of the virHashForEach callback to match the name
> of the Export function with the Callback added onto it.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/virsecretobj.c | 31 ++++++++++++++-----------------
>  1 file changed, 14 insertions(+), 17 deletions(-)

ACK

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170425/8a2fbeda/attachment-0001.sig>


More information about the libvir-list mailing list