[libvirt] [PATCH v3 1/2] util: switch over to use keycodemapdb GIT submodule

Daniel P. Berrange berrange at redhat.com
Tue Apr 25 18:58:11 UTC 2017


On Tue, Apr 25, 2017 at 07:26:05PM +0200, Andrea Bolognani wrote:
> On Tue, 2017-04-25 at 14:51 +0100, Daniel P. Berrange wrote:
> > @@ -1,3 +1,6 @@
> >  [submodule "gnulib"]
> >  	path = .gnulib
> >  	url = git://git.sv.gnu.org/gnulib.git
> > +[submodule "src/keycodemapdb"]
> > +	path = src/keycodemapdb
> > +	url = https://gitlab.com/keycodemap/keycodemapdb.git
> 
> Small nit: please use "keycodemapdb" as submodule name
> instead of "src/keycodemapdb".

Ah, for some reason I was thinking it had to match the path.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list