[libvirt] [PATCH 15/15] nwfilter: Move and rename virNWFilterSaveConfig

[John Ferlan]

On 04/25/2017 10:37 AM, Pavel Hrdina wrote:
> On Mon, Apr 24, 2017 at 03:18:44PM -0400, John Ferlan wrote:
>> Move into virnwfilterobj, rename the API to virNWFilterObjSaveConfig,
>> and reorder the arguments.
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  src/conf/nwfilter_conf.c       | 20 --------------------
>>  src/conf/nwfilter_conf.h       |  4 ----
>>  src/conf/virnwfilterobj.c      | 23 ++++++++++++++++++++++-
>>  src/conf/virnwfilterobj.h      |  4 ++++
>>  src/libvirt_private.syms       |  3 ++-
>>  src/nwfilter/nwfilter_driver.c |  2 +-
>>  6 files changed, 29 insertions(+), 27 deletions(-)
> 
> I don't see any benefit of moving the function, it operates only on
> virNWFilterDefPtr so the current place is suitable and passing the whole
> obj instead of def doesn't improve anything, unless there is some other
> agenda and some future patches will benefit from this change.
> 
> Pavel
>  

Well... imagine if you will that...

nwfilterDefineXML calls virNWFilterObjListAssignDef which at some point
in the future would consume "configFile" as well as def. IOW: it becomes
part of the object.  Again, I'm working backwards here in order to make
the future easier.

Anyway, I'll rethink/rework that logic later so patches 13 and 15 end up
being dropped.

Tks -

John