[libvirt] [PATCH 4/4] cpu: Avoid c99 style of assembler

Daniel P. Berrange berrange at redhat.com
Thu Apr 27 08:22:04 UTC 2017


On Thu, Apr 27, 2017 at 09:24:54AM +0200, Peter Krempa wrote:
> On Thu, Apr 27, 2017 at 09:02:00 +0200, Michal Privoznik wrote:
> > In c89 - the standard we claim to support - there is no asm()
> 
> I'm not quite sure about the truth of this statement. Especially after
> commits like:
> 
> 0f6c46c3d virsh.c: Switch to C99 initialization of vshCmdOptDef
> 879d409e9 Convert all driver struct intializers to C99 style
> 
> and quite a lot more ...

Yep the C99 struct member initializers are a very valuable feature.
I'd say, we aim for c89, plus selected c99 features.

We explicitly try to avoid some other c99 features though, such variables
declared in the middle of functions.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list