[libvirt] [PATCH v2 4/5] qemu: add support for qemu-xhci USB controller

[Pavel Hrdina]

On Thu, Apr 27, 2017 at 08:40:22PM +0200, Andrea Bolognani wrote:
> On Thu, 2017-04-27 at 18:09 +0200, Pavel Hrdina wrote:
> >     - reduced one file by using link
> 
> Sorry I was not clear enough the first time around, but what
> I meant was that you can literally...
> 
> > --- /dev/null
> > +++ b/tests/qemuxml2argvdata/qemuxml2argv-usb-controller-qemu-xhci-unavailable.xml
> > @@ -0,0 +1 @@
> > +qemuxml2argv-usb-controller-qemu-xhci.xml
> > \ No newline at end of file
> 
> ... not add this file at all...
> 
> > @@ -1416,6 +1416,10 @@ mymain(void)
> >      DO_TEST_PARSE_ERROR("usb-controller-xhci-limit",
> >              QEMU_CAPS_CHARDEV, QEMU_CAPS_NODEFCONFIG, QEMU_CAPS_PIIX3_USB_UHCI,
> >              QEMU_CAPS_NEC_USB_XHCI, QEMU_CAPS_NEC_USB_XHCI_PORTS);
> > +    DO_TEST("usb-controller-qemu-xhci", QEMU_CAPS_DEVICE_QEMU_XHCI);
> > +    DO_TEST_FAILURE("usb-controller-qemu-xhci-unavailable", NONE);
> 
> ... and just use the usb-controller-qemu-xhci input file
> again for the failing test case.

No, this is not just what file should be used, it's also a name of the
test case and it should be unique.  It was clear the first time, but it
was not a good suggestion so I've used link instead.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170427/1c153ea1/attachment-0001.sig>