[libvirt] [PATCH 09/14] tests: genericxml2xml: Add test case for HTTP based disk

[Jiri Denemark]

On Wed, Apr 26, 2017 at 19:52:39 +0200, Peter Krempa wrote:
> ---
>  .../generic-disk-network-http.xml                  | 44 ++++++++++++++++++++++
>  tests/genericxml2xmltest.c                         |  1 +
>  2 files changed, 45 insertions(+)
>  create mode 100644 tests/genericxml2xmlindata/generic-disk-network-http.xml
> 
> diff --git a/tests/genericxml2xmlindata/generic-disk-network-http.xml b/tests/genericxml2xmlindata/generic-disk-network-http.xml
> new file mode 100644
> index 000000000..51c779502
> --- /dev/null
> +++ b/tests/genericxml2xmlindata/generic-disk-network-http.xml
> @@ -0,0 +1,44 @@
> +<domain type='qemu'>
> +  <name>QEMUGuest1</name>
> +  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
> +  <memory unit='KiB'>219136</memory>
> +  <currentMemory unit='KiB'>219136</currentMemory>
> +  <vcpu placement='static'>1</vcpu>
> +  <os>
> +    <type arch='i686' machine='pc'>hvm</type>
> +    <boot dev='hd'/>
> +  </os>
> +  <clock offset='utc'/>
> +  <on_poweroff>destroy</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>destroy</on_crash>
> +  <devices>
> +    <emulator>/usr/bin/qemu-system-i686</emulator>
> +    <disk type='network' device='disk'>
> +      <driver name='qemu' type='raw'/>
> +      <source protocol='http' name='test.img'>
> +        <host name='example.org'/>
> +      </source>
> +      <target dev='vda' bus='virtio'/>
> +    </disk>
...

I'd think a <readonly/> element would be mandatory for http(s) disks,
but apparently it isn't...

This patch ends the part of useful refactors and cleanups and my review
ends here too. Feel free to push everything I acked. The rest of the
series is related to HTTP cookies and some design decisions need to be
solved first. BTW, I tend to agree with Dan B.

Reviewed-by: Jiri Denemark <jdenemar at redhat.com>