[libvirt] [PATCH v2 07/38] iohelper: Remove unused mode

[Michal Privoznik]

On 04/27/2017 09:47 PM, John Ferlan wrote:
> 
> 
> On 04/20/2017 06:01 AM, Michal Privoznik wrote:
>> After 1eb6647979f8c nobody calls the iohelper with 6 arguments.
>> Everybody uses the other mode. Well, the only user of iohelper
>> after the previous commit is virFileWrapperFd really.
> 
> Are we talking two commits ago? 

No.

commit 1eb6647979f8c657958069a28df713deab3052a6
Author:     Eric Blake <eblake at redhat.com>
AuthorDate: Tue Jul 12 09:17:52 2011 -0600


> Couldn't this then be merged with that
> to make it more obvious with the commit message adjustment indicating
> now that the commit is the last consumer/caller of iohelper with so many
> arguments. It also shows where you've essentially moved the code.

This could be moved in front of 06/32 as it is independent of it. Even
without any other patch of the series this one can be pushed in. Nobody
uses this mode in iohelper for nearly 6 years.

> 
> ACK if I've read properly and this moves...

So do you read properly? ;-)

Michal