[libvirt] [libvirt-php PATCH 04/13] Split up the bindings for libvirt connection API
Michal Privoznik
mprivozn at redhat.com
Thu Aug 3 12:27:16 UTC 2017
On 08/01/2017 11:46 PM, Dawid Zamirski wrote:
> * add libvirt-connection.h and libvirt-connection.c
> * move all libvirt_connect_* function declarations and definitions to
> above files
> * other minor adjusments to libvirt-php.h and util.h to keep the code
> compilable while the code is being moved around.
> ---
> src/Makefile.am | 3 +-
> src/libvirt-connection.c | 885 +++++++++++++++++++++++++++++++++++++++++++++
> src/libvirt-connection.h | 83 +++++
> src/libvirt-php.c | 919 +----------------------------------------------
> src/libvirt-php.h | 104 +++---
> src/util.h | 7 -
> 6 files changed, 1024 insertions(+), 977 deletions(-)
> create mode 100644 src/libvirt-connection.c
> create mode 100644 src/libvirt-connection.h
Unfortunately, this breaks the build for me. I'm compiling with php5.6.
Moreover, as I try to fix the build I wonder if we can put all the php
differentiating code into util.h - it'd need to include php.h then (for
all those ZEND_* macros and zend_* types).
I'm pushing patches 02 and 03 meanwhile.
Michal
More information about the libvir-list
mailing list