[libvirt] [PATCH 5/8] virVMXParseConfig: Don't leak def->videos

Michal Privoznik mprivozn at redhat.com
Mon Aug 7 09:21:46 UTC 2017

On 08/04/2017 04:56 PM, Ján Tomko wrote:
> On Fri, Aug 04, 2017 at 04:22:33PM +0200, Michal Privoznik wrote:
>> This function calls virDomainDefAddImplicitDevices() which adds
>> implicit video device to domain definition. However, later in the
>> process the function just ignores this and overwrites the @videos
>> array without prior free.
> We should not be calling virDomainDefAddImplicitDevices before
> all the explicit devices are added to the domain definition.
> What is the point of adding a device just to free it a few lines later?

Because the parsing code expects some controllers to be in place before
it gets to video devices. Just look around the place where
virDomainDefAddImplicitDevices() is called. If you have a bright idea
how to fix it I'm all ears.


More information about the libvir-list mailing list