[libvirt] [PATCH 0/2] Two Coverity Fixes (thanks John!)

Ján Tomko jtomko at redhat.com
Mon Aug 14 06:57:38 UTC 2017

On Sun, Aug 13, 2017 at 01:16:13PM -0400, John Ferlan wrote:
>On 08/13/2017 11:44 AM, Laine Stump wrote:
>> John found these two problems with Coverity after I pushed my series
>> fixing MAC address saving/setting on Mellanox dual port NICs.
>> Laine Stump (2):
>>   util: fix Coverity complaint (and actual bug) in
>>     virHostdevReadNetConfig()
>>   util: fix Coverity complaint in virNetDevSetNetConfig()
>>  src/util/virhostdev.c | 2 +-
>>  src/util/virnetdev.c  | 4 +---
>>  2 files changed, 2 insertions(+), 4 deletions(-)
>"Some" will say no need to call out Coverity in the short description,
>just somewhere in the commit message a "found by coverity" is
>sufficient.  And then there's others that are fine with it as is, your
>call ;-)

Yes, 'fix Coverity complaint (and actual bug)' carries pretty much the
same information as 'fix' while wasting way more precious commit summary

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170814/ed2e1e0e/attachment-0001.sig>

More information about the libvir-list mailing list