[libvirt] [PATCH 04/10] conf: use virXMLPropString for IOMMU def parsing

Ján Tomko jtomko at redhat.com
Wed Aug 16 15:02:38 UTC 2017


On Wed, Aug 16, 2017 at 02:40:41PM +0200, Pavel Hrdina wrote:
>XPath is good for random search of elements, not for accessing
>attributes of one node.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
>
>Notes:
>    hint: review with -b
>
> src/conf/domain_conf.c | 57 ++++++++++++++++++++++++++------------------------
> 1 file changed, 30 insertions(+), 27 deletions(-)
>

The STRDUP in virXPathString is still redundant, but not sure if it's
worth over-optimizning further.

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170816/f18f61d8/attachment-0001.sig>


More information about the libvir-list mailing list