[libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

Pavel Hrdina phrdina at redhat.com
Mon Aug 28 07:56:20 UTC 2017

On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote:
> Rather than require an explicit blacklist that needs to be extended
> for every new VIDEO_TYPE
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
>  src/qemu/qemu_domain.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)

NACK, we prefer to listing all possible values for typed switch.  It
forces a contributor to look at all places where that switch is used
in order to consider whether that place should be updated or not.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170828/a9c03d06/attachment-0001.sig>

More information about the libvir-list mailing list