[libvirt] [PATCH v6 12/13] tests: Add test for failure when vxhs_tls=0

Peter Krempa pkrempa at redhat.com
Thu Aug 31 14:17:35 UTC 2017

On Wed, Aug 30, 2017 at 18:46:12 -0400, John Ferlan wrote:
> From: Ashish Mittal <Ashish.Mittal at veritas.com>
> Add a test case to verify setting vxhs_tls=0 in qemu.conf disables
> TLS for VxHS disks followed by running the same test after enabling
> for the success case.
> Signed-off-by: Ashish Mittal <Ashish.Mittal at veritas.com>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  This is essentially the same v5 patch8 - had to clean up the input
>  XML a bit though.
>  I'm not a fan of this change - I think we should just follow what
>  chardev does and if someone has vxhs_tls = 0 and haveTLS = true,
>  then we just clear the haveTLS and move on.  I think one way or
>  another things will fail in any case.

Me neither. NACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170831/bdc09deb/attachment-0001.sig>

More information about the libvir-list mailing list