[libvirt] [PATCH] activate and refresh logical volumes while refreshing logical pool

[Ján Tomko]

On Tue, Aug 01, 2017 at 04:26:07PM +0300, Vasiliy Tolstov wrote:
>Signed-off-by: Vasiliy Tolstov <v.tolstov at selfip.ru>
>---
> src/storage/storage_backend_logical.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
>diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
>index 67f70e551729..0c34476de38e 100644
>--- a/src/storage/storage_backend_logical.c
>+++ b/src/storage/storage_backend_logical.c
>@@ -811,6 +811,25 @@ virStorageBackendLogicalRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
>
>     virWaitForDevices();
>
>+    cmd = virCommandNewArgList("vgchange",
>+                               "-aay",
>+                               pool->def->source.name,
>+                               NULL);
>+    if (virCommandRun(cmd, NULL) < 0)
>+        goto cleanup;
>+

NACK,

pool refresh should make libvirt update its internal state to match
the on-disk state. Activating the volume should be done by whatever
software created it.

Jan

>+    virCommandFree(cmd);
>+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170801/a74f9287/attachment-0001.sig>