[libvirt] [PATCH] tpm: Use /dev/null for cancel path if none was found

Javier Martinez Canillas javierm at redhat.com
Thu Aug 17 08:44:44 UTC 2017


Hello,

On 06/29/2017 08:01 PM, Stefan Berger wrote:
> TPM 2 does not implement sysfs files for cancellation of commands.
> We therefore use /dev/null for the cancel path passed to QEMU.
> 
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> ---
>  src/util/virtpm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/util/virtpm.c b/src/util/virtpm.c
> index 6d9b065..d5c10da 100644
> --- a/src/util/virtpm.c
> +++ b/src/util/virtpm.c
> @@ -61,9 +61,7 @@ virTPMCreateCancelPath(const char *devpath)
>                  VIR_FREE(path);
>              }
>              if (!path)
> -                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> -                               _("No usable sysfs TPM cancel file could be "
> -                                 "found"));
> +                ignore_value(VIR_STRDUP(path, "/dev/null"));
>          } else {
>              virReportError(VIR_ERR_INTERNAL_ERROR,
>                             _("TPM device path %s is invalid"), devpath);
> 

I see that this patch hasn't landed in libvirt yet.

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat




More information about the libvir-list mailing list