[libvirt] [PATCH v3 1/4] tests: qemuxml2argv: Use scsi controller instead of ide in pseries

[Ján Tomko]

On Fri, Dec 01, 2017 at 07:31:29PM +0800, Lin Ma wrote:
>Adding an IDE controller for a machinetype that has no built-in IDE
>controller, Libvirt will log an error. Currently the machinetype list
>which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx,
>malta, sun4u and g3beige.
>
>Signed-off-by: Lin Ma <lma at suse.com>
>---
> tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args | 2 +-
> tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.xml  | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args
>index 72a4183..44b5751 100644
>--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args
>+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args
>@@ -16,7 +16,7 @@ QEMU_AUDIO_DRV=none \
> -no-acpi \
> -boot c \
> -usb \
>--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=ide,bus=0,unit=0 \
>+-hda /dev/HostVG/QEMUGuest1 \
> -drive file=/dev/fd0,format=raw,if=floppy,unit=0 \
> -drive file=/tmp/firmware.img,format=raw,if=floppy,unit=1 \
> -net none \

This change is bogus, current libvirt should never generate -hda

The .args file can be dropped for this test case, since it expects
failure.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171201/e316a393/attachment-0001.sig>