[libvirt] [PATCH] Adjust backslash alignment syntax-check

Andrea Bolognani abologna at redhat.com
Mon Dec 4 10:06:16 UTC 2017


On Thu, 2017-11-23 at 06:46 +0100, Michal Privoznik wrote:
> > @@ -1038,7 +1038,7 @@ sc_prohibit_http_urls:
> >  	  $(_sc_search_regexp)
> >  
> >  sc_prohibit_backslash_alignment:
> > -	@prohibit='[[:blank:]][[:blank:]]\\$$' \
> > +	@prohibit='([[:blank:]][[:blank:]]|	)\\$$' \
> >  	in_vc_files='*\.([chx]|am|mk)$$' \
> >  	halt='Do not attempt to right-align backslashes' \
> >  	  $(_sc_search_regexp)
> > 
> 
> ACK

My use of [[:blank:]] was intended to cover tabs as well, but I
see now that it couldn't possibly work as intended :/

But since we've added the tab explicitly (good), maybe we can
replace the first part of the expression with two literal spaces
and make the whole thing more compact and just as effective?

I'll send a patch :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list