[libvirt] [PATCH v2] libvirt: Adding POWER9 DD1.0/DD2.0 PVR value to cpu_map.xml

[Andrea Bolognani]

On Tue, 2017-11-28 at 15:16 +0530, Seeteena Thoufeek wrote:
> DD1.0/DD2.0 PVR value is missing from cpu_map.xml. This patch
> provides those details
> 
> Signed-off-by: Seeteena Thoufeek <s1seetee at linux.vnet.ibm.com>
> ---
>  src/cpu/cpu_map.xml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
> index e5da7a8..be4e215 100644
> --- a/src/cpu/cpu_map.xml
> +++ b/src/cpu/cpu_map.xml
> @@ -1729,6 +1729,8 @@
>      <model name='POWER9'>
>        <vendor name='IBM'/>
>        <pvr value='0x004e0000' mask='0xffff0000'/>
> +      <pvr value='0x004e0100' mask='0xffff0000'/>
> +      <pvr value='0x004e1200' mask='0xffff0000'/>
>      </model>
>  
>      <!-- Freescale-based CPU models -->

Values match those used in QEMU[1], so that's good.

However I don't think we need this patch at all, since the first
four bytes are the same for all CPU revisions, and we will ignore
the remaining ones due to mask='0xffff0000'.

Did you encounter any actual failure which can be traced back to
those PVRs not being included in the cpu_map.xml file?


[1] https://github.com/qemu/qemu/blob/master/target/ppc/cpu-models.h#L373-L375
-- 
Andrea Bolognani / Red Hat / Virtualization