[libvirt] [PATCH 1/3] util: gettid() is Linux-specific

Andrea Bolognani abologna at redhat.com
Mon Dec 4 16:23:45 UTC 2017

The manual page clearly states that

  gettid() is Linux-specific and should not be used in programs
  that are intended to be portable.

Unfortunately, it looks like macOS implemented the functionality
and defined SYS_gettid accordingly, only to deprecate syscall()
altogether with 10.12 (Sierra), released last late year.

To avoid compilation errors, call gettid() on Linux only.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
 src/util/virthread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virthread.c b/src/util/virthread.c
index 6c495158f..05b5572f5 100644
--- a/src/util/virthread.c
+++ b/src/util/virthread.c
@@ -268,7 +268,7 @@ bool virThreadIsSelf(virThreadPtr thread)
  * the pthread_self() id on Linux.  */
 unsigned long long virThreadSelfID(void)
-#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid)
+#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid) && defined(__linux__)
     pid_t tid = syscall(SYS_gettid);
     return tid;

More information about the libvir-list mailing list