[libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

Jim Fehlig jfehlig at suse.com
Tue Dec 5 00:15:03 UTC 2017

On 12/04/2017 03:27 PM, Marek Marczykowski-Górecki wrote:
> On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote:
>> On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote:
>>> On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote:
>>>> There's another instance of this check in xenFormatNet() in
>>>> src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in
>>>> xml <-> xl.cfg conversions. Do you have time to fix the config converter
>>>> too?
>>> Where should I put helper function to not duplicate it across those two
>>> drivers?
>> Would there be duplicate code? The two serve different purposes. xenconfig
>> converts libvirt domXML to/from the various Xen config formats (xl, xm,
>> sexpr). The libxl driver maps virDomainDef to libxl_domain_config.
> In both cases I need a function that makes a space-separated list of IP
> addresses, out of virNetDevIPInfo struct.

Given the current contents of src/xenconfig/xen_common.{ch}, I suppose it is the 
best fit. The contents of src/xenconfig can be folded into src/libxl once the 
old xend driver is removed, making this a bit cleaner.

> But the same question applies also to a loong waiting cpuid patch series
> (there: preparing libxl cpuid features string)...

Heh, I was going to ask you about that series :-). Sorry, I didn't realize you 
were waiting on me. At any rate, same answer as above. Will you be rebasing and 
resubmitting it?


More information about the libvir-list mailing list