[libvirt] [PATCH 00/17] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks

John Ferlan jferlan at redhat.com
Tue Dec 5 01:38:50 UTC 2017


Recent series to just move IDE checks:

(v4: https://www.redhat.com/archives/libvir-list/2017-December/msg00049.html)

gave me enough "push" in order to move the bulk of qemu_command controller
command line build "validation" checks into their own Validation helpers.

The IDE only checks are essentially incorporated into this series.



John Ferlan (14):
  qemu: Introduce qemuDomainDeviceDefValidateController
  qemu: Introduce qemuDomainDeviceDefSkipController
  qemu: Use virDomainControllerType in qemuBuildControllerDevStr switch
  qemu: Move CCW S390 Address check to controller def validate
  qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI
  qemu: Introduce qemuDomainDeviceDefValidateControllerPCI
  qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr
  qemu: Move PCI command modelName check to controller def validate
  qemu: Move PCI command modelName TypeToString to controller def
    validate
  qemu: Move PCI more command checks to controller def validate
  qemu: Complete PCI command checks to controller def validate
  qemu: Introduce qemuDomainDeviceDefValidateControllerSATA
  qemu: Introduce qemuDomainDeviceDefValidateControllerUSB
  qemu: Complete move USB command checks to controller def validate

Lin Ma (3):
  tests: Remove use of IDE disk for pseries floppy test
  tests: Drop IDE controller in CCW
  qemu: Introduce qemuDomainDeviceDefValidateControllerIDE

 src/qemu/qemu_command.c                            | 566 ++------------------
 src/qemu/qemu_command.h                            |   2 +
 src/qemu/qemu_domain.c                             | 590 ++++++++++++++++++++-
 src/qemu/qemu_domain.h                             |  12 +
 .../qemuhotplug-base-ccw-live+ccw-virtio.xml       |   4 -
 ...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml |   4 -
 ...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml |   4 -
 ...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml |   4 -
 ...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml |   4 -
 ...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml |   4 -
 .../qemuhotplug-base-ccw-live-with-ccw-virtio.xml  |   4 -
 .../qemuhotplug-base-ccw-live.xml                  |   4 -
 tests/qemumemlocktest.c                            |  14 +
 .../qemuxml2argv-disk-floppy-pseries.args          |  24 -
 .../qemuxml2argv-disk-floppy-pseries.xml           |   7 -
 tests/qemuxml2argvtest.c                           |  18 +-
 tests/qemuxml2xmltest.c                            |  20 +-
 17 files changed, 689 insertions(+), 596 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args

-- 
2.13.6




More information about the libvir-list mailing list