[libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases
Michal Privoznik
mprivozn at redhat.com
Tue Dec 5 06:45:34 UTC 2017
On 12/04/2017 06:04 PM, Andrea Bolognani wrote:
> On Sat, 2017-12-02 at 08:11 +0100, Michal Privoznik wrote:
>> The patches are trimmed out a lot to fit the size limit of our list. Anyway,
>> the interesting bits are kept and also you can find the patches at my github:
>>
>> https://github.com/zippy2/libvirt/commits/qemuxml2argvdata
>>
>> If this approach is ACKed, I can continue because some other files suffer the
>> same problem (e.g. qemuxml2xmloutdata).
>>
>> Michal Privoznik (2):
>> tests: Drop qemuxml2argv- prefix for qemuxml2argv-*.xml test cases
>> tests: Drop qemuxml2argv- prefix for qemuxml2argv test cases
>>
>> tests/qemuxml2argvtest.c | 4 ++--
>> tests/qemuxml2xmltest.c | 2 +-
>> <very long list of renames/>
>> 1481 files changed, 57 insertions(+), 57 deletions(-)
>
> Yes please!
>
> I suggest you wait a few days before pushing so that other people
> have a chance to chime in, but as far as I'm concerned
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> for the whole series, and looking forward to more of this :)
>
Cool. Looks like we have a wide agreement on this. What's even more
interesting is that the resulting .tar.xz is rougly ~5KiB smaller with
this change. Frankly, I hoped that xz compresses the file names too.
Whatever, I've pushed these. Thanks!
Michal
More information about the libvir-list
mailing list