[libvirt] [PATCH 05/17] tests: Remove use of IDE disk for pseries floppy test

Ján Tomko jtomko at redhat.com
Tue Dec 5 13:47:17 UTC 2017


On Mon, Dec 04, 2017 at 08:38:55PM -0500, John Ferlan wrote:
>From: Lin Ma <lma at suse.com>
>
>Adding an IDE controller for a machinetype that has no built-in IDE
>controller, libvirt will log an error. Currently the machinetype list
>which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx,
>malta, sun4u and g3beige.
>
>Remove the disk and the .args file since the expectation is the test
>will fail in qemuxml2argvtest because floppy is not supported on pseries
>and thus no disk is necessary and no .args file would be created to
>compare against.
>
>Signed-off-by: Lin Ma <lma at suse.com>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> .../qemuxml2argv-disk-floppy-pseries.args          | 24 ----------------------
> .../qemuxml2argv-disk-floppy-pseries.xml           |  7 -------
> 2 files changed, 31 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171205/67658583/attachment-0001.sig>


More information about the libvir-list mailing list