[libvirt] [sandbox 5/6] Convert to python3

[Daniel P. Berrange]

On Wed, Dec 06, 2017 at 01:50:56PM +0100, Cedric Bosdonnat wrote:
> On Tue, 2017-12-05 at 16:57 +0000, Daniel P. Berrange wrote:
> > On Tue, Dec 05, 2017 at 10:53:21AM +0100, Cédric Bosdonnat wrote:
> > > Python2 is going to die soon, convert to python3.
> > 
> > I'm unclear whether this change drops py2 support, or whether it makes it
> > work with py2+3 in parallel.
> > 
> > The commit message suggests py3 only, but then this:
> > 
> > > @@ -418,6 +416,18 @@ class GenericContainer(Container):
> > >  def is_template_unit(unit):
> > >      return '@' in unit
> > >  
> > > +# Python 2 / 3 compability helpers
> > > +def get_next(obj):
> > > +    if hasattr(obj, 'next'):
> > > +        return obj.next()
> > > +    else:
> > > +        return next(obj)
> > > +
> > > +def string(obj):
> > > +    if isinstance(obj, bytes):
> > > +        return str(obj, encoding='utf-8')
> > > +    return obj
> > 
> > 
> > suggests py2+3 in parallel
> > 
> > I don't mind being py3 only.
> > 
> Oops, that one is a left over. I'll remove it and drop python2.
> And at least the commit message will be in sync with the code

Ok, ack with that dropped

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|