[libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED

[Chen Hanxiao]

At 2017-12-07 17:30:15, "Michal Privoznik" <mprivozn at redhat.com> wrote:
>On 12/07/2017 02:59 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at gmail.com>
>> 
>> Since commit 5e5019bf, we've no longer use
>> VIR_ERR_AGENT_UNSYNCED anymore.
>> Mark it as DEPRECATED.
>> 
>> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
>> ---
>>  include/libvirt/virterror.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
>> index d2b5f1fd4..91ba29784 100644
>> --- a/include/libvirt/virterror.h
>> +++ b/include/libvirt/virterror.h
>> @@ -318,7 +318,7 @@ typedef enum {
>>      VIR_ERR_NO_SERVER = 95,             /* Server was not found */
>>      VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
>>      VIR_ERR_AGENT_UNSYNCED = 97,        /* guest agent replies with wrong id
>> -                                           to guest-sync command */
>> +                                           to guest-sync command (DEPRECATED)*/
>>      VIR_ERR_LIBSSH = 98,                /* error in libssh transport driver */
>>  } virErrorNumber;
>>  
>> 
>
>We don't really have 'deprecation' methods for libvirt.
>I wish we had.

I just saw a similar mark at:

https://github.com/libvirt/libvirt/blob/master/include/libvirt/virterror.h#L233-L234

VIR_ERR_CALL_FAILED = 26,           /* not supported by the drivers
                                           (DEPRECATED) */


Regards,
- Chen


>
>Michal