[libvirt] [PATCH] qemu: blockjob: Reset disk source index after pivot

Eric Blake eblake at redhat.com
Thu Dec 7 19:28:25 UTC 2017


On 12/07/2017 09:27 AM, Peter Krempa wrote:
> Since we are re-detecting the backing chain after pivoting to the active
> block commit target (or block copy target) the disk index needs to be
> reset to 0. This is necessary since we move a member of the backing
> chain to disk->src but clear indexes only starting from
> disk->src->backingStore. The freshly detected images have indexes
> starting from 1, but since we've pivoted into an image which was
> previously a backing store it would have a non-0 index.
> The lookup function would then return the top of the chain for queries
> like 'vda[1]' instead of the first backing store.
> 
> This problem will not be present once we keep the disk indexes stable.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1519745
> ---
>  src/qemu/qemu_blockjob.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171207/1bd75cce/attachment-0001.sig>


More information about the libvir-list mailing list