[libvirt] [libvirt-php][PATCH 0/7] Rework libvirt_domain_new a bit

Erik Skultety eskultet at redhat.com
Fri Dec 8 08:54:40 UTC 2017


On Thu, Dec 07, 2017 at 10:22:55AM +0100, Michal Privoznik wrote:
> Patches for: https://bugzilla.redhat.com/show_bug.cgi?id=1513190
>
> You can also get the patches from my github:
>
> https://github.com/zippy2/libvirt-php/commits/libvirt_domain_new
>
> Apart from usual case where I just push patches immediately, I'm gonna give
> others chance to review since it's not trivial change set.

Since you're doing some basic cleanup, I'd suggest adding a patch to remove
single line commentaries, especially some old/testing assignments, expressions,
etc.

Erik




More information about the libvir-list mailing list