[libvirt] [PATCH v3 04/12] qemu: Introduce qemuDomainDeviceDefValidateControllerIDE

Ján Tomko jtomko at redhat.com
Fri Dec 8 14:49:45 UTC 2017


On Wed, Dec 06, 2017 at 08:14:00PM -0500, John Ferlan wrote:
>From: Lin Ma <lma at suse.com>
>
>Move the IDE controller check from command line building to
>controller def validation. Also explicitly include the avoidance
>check for the implicit IDE controller from qemuBuildSkipController.
>
>Cause the IDE case for command line building to generate a
>failure if called to add an IDE since that shouldn't happen
>if the Validate code did the right thing.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> src/qemu/qemu_command.c | 16 ----------------
> src/qemu/qemu_domain.c  | 33 ++++++++++++++++++++++++++++++++-
> 2 files changed, 32 insertions(+), 17 deletions(-)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171208/5f604277/attachment-0001.sig>


More information about the libvir-list mailing list