[libvirt] [libvirt-php][PATCH 2/5] src: Don't leak @uuid in libvirt_nwfilter_get_uuid_string

Erik Skultety eskultet at redhat.com
Mon Dec 11 07:54:41 UTC 2017


On Mon, Dec 11, 2017 at 07:34:56AM +0100, Michal Privoznik wrote:
> VIRT_RETURN_STRING() does immediate return. Therefore,
> efree(uuid) is never called and thus leaked. Moreover, there's no
> reason for dynamically allocated uuid buffer (in contrast to our
> misuse of large static buffers).
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list